Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix volume assignment for chords + repeat from GUI #296

Merged
merged 4 commits into from
Oct 17, 2023
Merged

fix volume assignment for chords + repeat from GUI #296

merged 4 commits into from
Oct 17, 2023

Conversation

scaredycode
Copy link
Collaborator

No description provided.

@scaredycode scaredycode self-assigned this Oct 12, 2023
@scaredycode scaredycode added bug Something isn't working behavior labels Oct 12, 2023
Juphex
Juphex reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@Juphex Juphex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the working code?

@Flova
Copy link
Collaborator

Flova commented Oct 14, 2023

Looks good, but we still need to test it.

yl-wang996
yl-wang996 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@yl-wang996 yl-wang996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you tested the re pattern, then I think it is good to go.

@Flova Flova merged commit 86c2f0b into main Oct 17, 2023
2 checks passed
@Flova Flova deleted the fix/volume_assignment branch October 17, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juphex Juphex Juphex left review comments

@yl-wang996 yl-wang996 yl-wang996 approved these changes

@Flova Flova Flova approved these changes

Assignees

@scaredycode scaredycode

Labels
behavior bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scaredycode @Flova @Juphex @yl-wang996